Define type Regex and implement RegexDestroy() #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrating from PCRE to PCRE2 we had to make a change
breaking API because all the functions working with REs were
using the PCRE's type `pcre`. To avoid this change in the future,
we define our own type `Regex` which we can later redefine
without causing any API breakage.
This also requires a definition of `RegexDestroy()` for use
instead of `pcre2_code_free()`.
Ticket: ENT-10629
Changelog: API working with regular expressions uses a custom
type Regex instead of pcre2_code directly
|
There was an error running your pipeline, see logs for details. |
craigcomstock
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating from PCRE to PCRE2 we had to make a change breaking API because all the functions working with REs were using the PCRE's type
pcre. To avoid this change in the future, we define our own typeRegexwhich we can later redefine without causing any API breakage.This also requires a definition of
RegexDestroy()for use instead ofpcre2_code_free().Ticket: ENT-10629
Changelog: API working with regular expressions uses a custom
type Regex instead of pcre2_code directly