-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fancy and more efficient syscalls to copy (sparse) files on Linux #218
Use fancy and more efficient syscalls to copy (sparse) files on Linux #218
Conversation
There was an error running your pipeline, see logs for details. |
0bfb82d
to
08935a5
Compare
There was an error running your pipeline, see logs for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🚀
08935a5
to
2cf2738
Compare
There was an error running your pipeline, see logs for details. |
2cf2738
to
cae11d6
Compare
There was an error running your pipeline, see logs for details. |
cae11d6
to
d26863d
Compare
There was an error running your pipeline, see logs for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, a few smaller comments.
There was an error running your pipeline, see logs for details. |
55d0157
to
b23d9f4
Compare
There was an error running your pipeline, see logs for details. |
b23d9f4
to
ee77078
Compare
There was an error running your pipeline, see logs for details. |
ee77078
to
a6d6640
Compare
There was an error running your pipeline, see logs for details. |
a6d6640
to
568d3a3
Compare
There was an error running your pipeline, see logs for details. |
568d3a3
to
9988c09
Compare
There was an error running your pipeline, see logs for details. |
The FICLONE ioctl() is the most efficient way to copy a file inside one file system if available and supported. copy_file_range() is an alternative that can provide similar efficiency, but also only works inside one file system and requires us to take care of holes in files. sendfile() is very similar, but unline copy_file_range() it doesn't support reflinks. Ticket: CFE-4380 Changelog: FileSparseCopy() now uses FICLONE ioctl(), copy_file_range() or sendfile() on Linux platforms (if available)
9988c09
to
e644c0c
Compare
There was an error running your pipeline, see logs for details. |
The FICLONE ioctl() is the most efficient way to copy a file inside one file system if available and supported. copy_file_range() is an alternative that can provide similar efficiency, but also only works inside one file system and requires us to take care of holes in files. sendfile() is very similar, but unline copy_file_range() it doesn't support reflinks.
Ticket: CFE-4380
Changelog: FileSparseCopy() now uses FICLONE ioctl(),
copy_file_range() or sendfile() on Linux
platforms (if available)