Merge pull request #440 from Nosto/release/3.8.0-RC2

Fix feature access bug & small refactoring
Nosto · Sep 26, 2018 · e52c1a2 · e52c1a2
2 parents 8a8e874 + c4bc017
commit e52c1a2
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 All notable changes to this project will be documented in this file. This project adheres to Semantic Versioning.
 
+### 3.8.0-RC2
+* Fix bug for checking if graphql feature is available
+* Refactor method names
+
 ### 3.8.0-RC1
 * Add support for category personalization
 
@@ -38,7 +42,7 @@ All notable changes to this project will be documented in this file. This projec
 
 ### 3.6.0
 * Improve error bubbling in Nosto account opening and in API calls
-* Add marketing permission constent for user tagging in order confirmation (GDPR compatibility) 
+* Add marketing permission consent for user tagging in order confirmation (GDPR compatibility) 
 
 ### 3.5.5
 * Fix the bundle product list price was incorrect if there is any optional item

diff --git a/app/code/community/Nosto/Tagging/Block/Product/List/Toolbar.php b/app/code/community/Nosto/Tagging/Block/Product/List/Toolbar.php
@@ -93,7 +93,7 @@ protected function getSortIds($type)
         $helper = Mage::helper('nosto_tagging/account');
         $account = $helper->find();
 
-        return $categoryService->getSortedProductIdsForToplist(
+        return $categoryService->getSortedProductIds(
             $account,
             $nostoVisitId,
             $category,

diff --git a/app/code/community/Nosto/Tagging/Helper/Data.php b/app/code/community/Nosto/Tagging/Helper/Data.php
@@ -199,7 +199,7 @@ class Nosto_Tagging_Helper_Data extends Mage_Core_Helper_Abstract
     /**
      * The release candidate version. Set to null for stable.
      */
-    const NOSTO_RC_VERSION = 1;
+    const NOSTO_RC_VERSION = 2;
 
     /**
      * List of strings to remove from the default Nosto account title

diff --git a/app/code/community/Nosto/Tagging/Model/Service/Recommendation/Category.php b/app/code/community/Nosto/Tagging/Model/Service/Recommendation/Category.php
@@ -45,7 +45,7 @@ class Nosto_Tagging_Model_Service_Recommendation_Category
      * @param string $type
      * @return array
      */
-    public function getSortedProductIdsForToplist(
+    public function getSortedProductIds(
         Nosto_Object_Signup_Account $nostoAccount,
         $nostoCustomerId,
         $category,
@@ -54,7 +54,7 @@ public function getSortedProductIdsForToplist(
     {
         $productIds = array();
         $featureAccess = new Nosto_Service_FeatureAccess($nostoAccount);
-        if ($featureAccess->canUseGraphql()) {
+        if (!$featureAccess->canUseGraphql()) {
             return $productIds;
         }
         switch ($type){

diff --git a/composer.json b/composer.json
@@ -23,7 +23,7 @@
     },
     "require": {
         "php": ">=5.4.0",
-        "nosto/php-sdk": "3.6.0"
+        "nosto/php-sdk": "3.6.1"
     },
     "require-dev": {
         "mridang/magazine": "0.1",

diff --git a/composer.lock b/composer.lock