Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Ensure openai is installed before importing init #65

Merged
merged 5 commits into from
Dec 18, 2024
Merged

chore: Ensure openai is installed before importing init #65

merged 5 commits into from
Dec 18, 2024

Conversation

acompa
Copy link
Contributor

@acompa acompa commented Dec 17, 2024

No description provided.

@acompa acompa requested review from huiruru and r0ymanesco December 17, 2024 22:28
r0ymanesco
r0ymanesco approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@r0ymanesco r0ymanesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch approving bc I'm not sure why that one test errored. Seems like it can't find the airbnb_tos.md file but that hasn't happened before

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  notdiamond
  __init__.py 15-17
  notdiamond/toolkit/litellm
  main.py
  notdiamond/toolkit/rag
  evaluation.py
  testset.py
  workflow.py
  tests/test_toolkit/rag
  test_data_gen.py
  test_example_workflow.py
Project Total  

This report was generated by python-coverage-comment-action

huiruru
huiruru reviewed Dec 18, 2024
View reviewed changes
Copy link

@huiruru huiruru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on the failing test - it looks like upgrading unstructured to 0.16.11 will fix it.

@acompa acompa merged commit bbe40b9 into main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huiruru huiruru huiruru left review comments

@r0ymanesco r0ymanesco r0ymanesco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acompa @huiruru @r0ymanesco