Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: backoff as global or per-model config. #66

Merged
merged 2 commits into from
Dec 19, 2024
Merged

feat: backoff as global or per-model config. #66

merged 2 commits into from
Dec 19, 2024

Conversation

acompa
Copy link
Contributor

@acompa acompa commented Dec 19, 2024

As discussed with @t5-notdiamond

@acompa acompa requested review from huiruru and r0ymanesco December 19, 2024 01:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

r0ymanesco
r0ymanesco approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@r0ymanesco r0ymanesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker but can you add in the doc string that the backoff is applied per retry?

@acompa acompa merged commit 5116a08 into main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0ymanesco r0ymanesco r0ymanesco approved these changes

@huiruru huiruru Awaiting requested review from huiruru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acompa @r0ymanesco