Fixes #29 - Add undo #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotWoods
requested changes
Oct 10, 2021
There was a problem hiding this comment.
I'd prefer to have a single undo stack rather than 1 stack per layer. Currently, switching to a different layer and pressing undo will only undo changes on that layer.
I'd like these steps to work:
- Change X position of Background layer
- Add new layer
- Press undo
- See X position of Background layer reset
Would also be nice if add/delete layer could be undone. I'm OK leaving that for another PR.
src/editor/main.js
Outdated
| copyLayer | ||
| ); | ||
|
|
||
| historyList = new Array(); |
There was a problem hiding this comment.
Suggested change
| historyList = new Array(); | |
| historyList = [initialHistory]; |
NotWoods
approved these changes
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are able to
control zto get back to their preview settingsOne more thing, can you label this as
hacktoberfest