[feat] Implement basic ELAN (Efficient Layer Aggregation Networks) #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illian01
reviewed
Nov 12, 2024
Comment on lines
853
to
856
| class ELAN(nn.Module): | ||
| """ | ||
| basic ELAN structure. | ||
| """ |
There was a problem hiding this comment.
Can you add paper reference where this module idea came from?
And if this code is copied version and not self-implemented from paper, please add reference of original codebase.
There was a problem hiding this comment.
Thank you for reviewing the implementation.
I would upload the url for the reference with additional commit! 👍
ref: https://github.com/WongKinYiu/YOLO/blob/main/yolo/model/module.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to present ELAN basic block.
Related to #582
We recommend to link at least one existing issue for PR. Before your create a PR, please check if there is an issue for this change.
Change(s)
Code Formatting
If you PR to either
masterordevbranch, you should follow the code linting process. Please check your code withlint_check.shin./scriptsdirectory.For more information, please read the contribution guide in
CONTRIBUTING.md.Changelog
If your PR is granted to
devbranch, codeowner will add a brief summary of the change to the Upcoming Release section of theCHANGELOG.mdfile including a link to the PR (formatted in markdown) and a link to your github profile.For example,
Please enable Allow edits and access to secrets by maintainers so that our maintainers can update the
CHANGELOG.md.