-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Consolidate Bounding box Transformation and IoU Calculation Functions #587
Merged
illian01
merged 21 commits into
Nota-NetsPresso:dev
from
hglee98:582-enhance-bbox-utils
Nov 26, 2024
Merged
Refactor: Consolidate Bounding box Transformation and IoU Calculation Functions #587
illian01
merged 21 commits into
Nota-NetsPresso:dev
from
hglee98:582-enhance-bbox-utils
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illian01
reviewed
Nov 12, 2024
illian01
added
refactoring
Changes code or architecture internally without changing the output.
enhancement
New feature or request
labels
Nov 12, 2024
illian01
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
refactoring
Changes code or architecture internally without changing the output.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to refactor bbox transformation and iou calculation function.
Closes: N/A
We recommend to link at least one existing issue for PR. Before your create a PR, please check if there is an issue for this change.
Change(s)
1. New Module Creation
netspresso_trainer.utils.bbox_utils
module2. IOU Metrics Consolidation
3. Introduction of Universal
transform_bbox
FunctionPrevious Implementation
Previously, we needed separate functions for each bbox format conversion:
New Implementation
Code Formatting
If you PR to either
master
ordev
branch, you should follow the code linting process. Please check your code withlint_check.sh
in./scripts
directory.For more information, please read the contribution guide in
CONTRIBUTING.md
.Changelog
If your PR is granted to
dev
branch, codeowner will add a brief summary of the change to the Upcoming Release section of theCHANGELOG.md
file including a link to the PR (formatted in markdown) and a link to your github profile.For example,
Please enable Allow edits and access to secrets by maintainers so that our maintainers can update the
CHANGELOG.md
.