Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Relocate anchor2vec outside the model #601

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

hglee98
Copy link
Contributor

@hglee98 hglee98 commented Dec 20, 2024

Description

This PR addresses the model compression issues mentioned in #582 by restructuring the Anchor2Vec implementation for compatibility with PyNetsPresso compression framework.

Related to #582

Changes

  • Relocate Anchor2Vec module outside the model architecture to enable proper compression
  • Refactor Anchor2Vec logic for improved functionality
  • Add reg_max configuration parameter to both loss function and post-processor components

Code Formatting

If you PR to either master or dev branch, you should follow the code linting process. Please check your code with lint_check.sh in ./scripts directory.
For more information, please read the contribution guide in CONTRIBUTING.md.

Changelog

If your PR is granted to dev branch, codeowner will add a brief summary of the change to the Upcoming Release section of the CHANGELOG.md file including a link to the PR (formatted in markdown) and a link to your github profile.

For example,

- Added a new feature by `@myusername` in [PR 2023](https://github.com/Nota-NetsPresso/netspresso-trainer/pull/2023)

Please enable Allow edits and access to secrets by maintainers so that our maintainers can update the CHANGELOG.md.

@hglee98 hglee98 requested a review from illian01 as a code owner December 20, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant