completed

Issue imixs#174
NourEldin-Ali · Feb 19, 2023 · d17f7e5 · d17f7e5
1 parent 25b2aaf
commit d17f7e5
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/...bpmn.glsp-server/src/main/java/org/openbpmn/extension/SignalEventDefinitionExtension.java b/...bpmn.glsp-server/src/main/java/org/openbpmn/extension/SignalEventDefinitionExtension.java
@@ -126,12 +126,14 @@ public void buildPropertiesForm(final BPMNElement bpmnElement, final DataBuilder
             for (Element definition : signalEventDefinitions) {
                 dataBuilder.addObject();
                 String signalRefID = definition.getAttribute("signalRef");
-                // fetch the corresponding Signal
-                Signal bpmnSignal = (Signal) modelState.getBpmnModel().findElementById(signalRefID);
-                if (bpmnSignal != null) {
-                    dataBuilder.addData("signal", bpmnSignal.getName());
-                } else {
-                    logger.warn("invalid signalRefID found: " + signalRefID);
+                if (!signalRefID.isEmpty()) {
+                    // fetch the corresponding Signal
+                    Signal bpmnSignal = (Signal) modelState.getBpmnModel().findElementById(signalRefID);
+                    if (bpmnSignal != null) {
+                        dataBuilder.addData("signal", bpmnSignal.getName());
+                    } else {
+                        logger.warn("invalid signalRefID found: " + signalRefID);
+                    }
                 }
 
             }
@@ -151,7 +153,7 @@ public void buildPropertiesForm(final BPMNElement bpmnElement, final DataBuilder
     public void updatePropertiesData(final JsonObject json, final BPMNElement bpmnElement,
             final GModelElement gNodeElement) {
         Event bpmnEvent = (Event) bpmnElement;
-        JsonArray dataList = json.getJsonArray("links");
+        JsonArray dataList = json.getJsonArray("signals");
 
         // synchronize the definition list of the event element
         Set<Element> signalEventDefinitions = synchronizeEventDefinitions("signalEventDefinition", bpmnEvent, dataList);