Enable/disable training on thinking tokens by configuration#117
Draft
mdawn65 wants to merge 1 commit intoNovaSky-AI:mainfrom
Draft
Enable/disable training on thinking tokens by configuration#117mdawn65 wants to merge 1 commit intoNovaSky-AI:mainfrom
mdawn65 wants to merge 1 commit intoNovaSky-AI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a configuration option to enable or disable training on "thinking tokens" for Qwen3 models in the generator. Works on issue #104.
Changes
get_custom_chat_templateto accept atrain_on_thinking_tokensflag.train_on_thinking_tokensconfig fromgenerator_cfgtoget_custom_chat_template.