[Doc] Add a doc page for SkyRLGymGenerator, multi-turn rollout/tokenization#186
Merged
tyler-griggs merged 4 commits intoNovaSky-AI:mainfrom Aug 27, 2025
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new documentation page for SkyRLGymGenerator, explaining its multi-turn tokenization behavior and the different codepaths. This allows for the removal of detailed comments from the source code, improving its readability. The changes are well-structured and the new documentation is comprehensive. I've provided a few suggestions to improve the clarity and correct some minor typos in the new documentation file.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
14 tasks
Member
|
I'll take a look at this today! If you get a sec, could you add screenshots of the rendered doc? |
Collaborator
Author
|
Yep, rendered docs: 
|
tyler-griggs
approved these changes
Aug 27, 2025
dzorlu
referenced
this pull request
in fleet-ai/SkyRL
Feb 4, 2026
…zation (#186) This PR adds a documentation page detailing the behavior of `SkyRLGymGenerator`, including the 3 codepaths described in NovaSky-AI#152, how multi-turn and single-turn rollouts/tokenizations work, and how token-in-token-out is enforced. As a result, we can remove some bulky comments in `skyrl_gym_generator.py` --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a documentation page detailing the behavior of
SkyRLGymGenerator, including the 3 codepaths described in #152, how multi-turn and single-turn rollouts/tokenizations work, and how token-in-token-out is enforced.As a result, we can remove some bulky comments in
skyrl_gym_generator.py