Skip to content

[Examples] Minor fix after #190 #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SumanthRH merged 2 commits into from
Aug 28, 2025
Merged

[Examples] Minor fix after #190 #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aebbe38
x
SumanthRH Aug 28, 2025
b4a5249
x
SumanthRH Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skyrl-train/examples/search/run_search_conversation_format.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ set -x
# follow the instructions in examples/search/README.md for setting up the dataset
# and for starting the local search server
# export WANDB_API_KEY=<your_key_here>
# bash examples/search/run_search.sh
# bash examples/search/run_search_conversation_format.sh

# path for dataset (.parquet files) containing the prompts and metadata for each question
DATA_DIR="$HOME/data/searchR1"
Expand Down
4 changes: 2 additions & 2 deletions skyrl-train/examples/text_to_sql/run_skyrl_sql_conversation_format.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
set -x

# The exact same script as `run_search.sh` but with `use_conversation_multi_turn=true`
# The exact same script as `run_skyrl_sql.sh` but with `use_conversation_multi_turn=true`
# and hence `append_eos_token_after_stop_str_in_multi_turn=true`
# See https://skyrl.readthedocs.io/en/latest/tutorials/skyrl_gym_generator.html on what behavior
# use_conversation_multi_turn corresponds to. You might want to change the data generation prompt
Expand All @@ -11,7 +11,7 @@ set -x
# Uses 1 node with 8 GPUs.
# huggingface-cli download NovaSky-AI/SkyRL-SQL-653-data-newfmt --local-dir $HOME/data/sql --repo-type dataset
# export WANDB_API_KEY=<your_key_here>
# bash examples/text_to_sql/run_skyrl_sql.sh
# bash examples/text_to_sql/run_skyrl_sql_conversation_format.sh

# change these paths to your own
DATA_DIR="$HOME/data/sql"
Expand Down