Revert "[Fix] Fix pass_at_k missing for SkRLGymGenerator.agent_loop flow due to token-level rewards"#300
Merged
erictang000 merged 1 commit intomainfrom Sep 16, 2025
Conversation
…low due …" This reverts commit 3ffaa10.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts a recent change that caused errors. The reverted code was intended to handle per-trajectory rewards as floats to enable pass_at_k calculation, but it introduced regressions. This PR restores the previous behavior where rewards are consistently handled as token-level lists. The changes are applied correctly in skyrl_train/skyrl_train/generators/skyrl_gym_generator.py and the corresponding tests are updated to reflect the reverted logic. The revert is clean and a good measure to ensure stability.
erictang000
approved these changes
Sep 16, 2025
dzorlu
pushed a commit
to fleet-ai/SkyRL
that referenced
this pull request
Feb 4, 2026
…low due to token-level rewards" (NovaSky-AI#300) Reverts NovaSky-AI#271 as it causes errors For more, see NovaSky-AI#299 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #271 as it causes errors
For more, see #299 (comment)