Resolve URL encoding bug

Closes #2495
Novik · Apr 27, 2023 · b0f3ab4 · b0f3ab4
1 parent e03b5a2
commit b0f3ab4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/js/rtorrent.js b/js/rtorrent.js
@@ -317,7 +317,8 @@ rTorrentStub.prototype.list = function()
 
 rTorrentStub.prototype.setuisettings = function()
 {
-	this.content = "v="+encodeURIComponent(this.vs[0]);
+	// encodeURIComponent is called inside webui.js to avoid injection
+	this.content = "v="+this.vs[0];
 	this.mountPoint = theURLs.SetSettingsURL;
 	this.contentType = "application/x-www-form-urlencoded";
 	this.dataType = "text";

diff --git a/js/webui.js b/js/webui.js
@@ -915,7 +915,8 @@ var theWebUI =
 			if((/^webui\./).test(i))
 				cookie[i] = v;
 		}
-		theWebUI.request("?action=setuisettings&v=" + JSON.stringify(cookie),reply);
+		// We must encode the URL here to avoid injection with the "&" symbol from search results
+		theWebUI.request("?action=setuisettings&v=" + encodeURIComponent(JSON.stringify(cookie),reply));
 	},
 
 //