Optimize WebUI.addTorrents #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request optimizes the
WebUI.addTorrent()function. It allows us to start rendering the WebUI, without having to wait for the torrent rows to refresh. In most cases, this reduces the TBT of the main thread by at least 50ms.The torrent rows now refresh asynchronously, so it doesn't slow down the adding of torrents into the WebUI. The function chain which invokes
dxSTable.refreshRows()can be done any time, as the objects are stored in the WebUI.With this pull request,
WebUI.loadTorrents()which invokesWebUI.show()now completes within 3ms instead of 60ms. The torrent rows will refresh when the main thread is no longer blocked and the WebUI has been shown.