improve graph theme support #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Novik
reviewed
Feb 11, 2022
| .addClass('graph_tab_tooltip') | ||
| .text(contents) | ||
| .css( { | ||
| position: 'absolute', |
There was a problem hiding this comment.
Maybe we should move 'position' to the class definition too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legend of the speed and traffic graphs did not look good in dark themes and was not customizable.
They can now be customized with the classes:
graph_tab_gridgraph_tab_legendgraph_tab_tooltipIn order to be able to read the styles properly, I added hidden elements to the DOM
with the classes
graph_tab_gridgraph_tab_legend