Plugin: check_port fix for portchecker.co #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylansama
changed the title
3 tasks
|
Fixes #2403 |
|
Thanks! I plan on merging this pull request. Just need some time to test it. I want to sneak it into ruTorrent 4.0 stable. |
|
Change tested. Works great. Thanks for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extremely simple fix to make this option work again. Was not being submitted to the correct url.
My personal usecase requires portchecker over yougetsignal because yougetsignal is returning my machine's ipv6 address. However it does not support checking ports for ipv6 addresses at all, so it's completely broken. Despite the port being open for both ipv6 and ipv4.
Whereas portchecker only returns ipv4 addresses. Will try and work on a fix for yougetsignal with an option to prefer ipv4 addresses when making http request, which should be all that is needed.