Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rss: Extract bbcode module #2621

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

TrimmingFool
Copy link
Contributor

#2569 (review)

Could we possibly make a new class for parsing bbcode to html and transforming it?

@stickz I extracted the bbcode logic into a module. (I think, a module is simpler than a new class, here.)

@stickz
Copy link
Collaborator

stickz commented Jan 1, 2024

Thanks, I will merge and test this in the new year. This will make the RSS plugin more robust in the long run.

@stickz stickz merged commit 9a0d72d into Novik:develop Mar 16, 2024
@fabricionaweb
Copy link

fabricionaweb commented May 17, 2024

This seems to broke the frontend rss test

 FAIL  plugins/rss/init.spec.js
  ● rss details › should sanitize html code

    TypeError: stub.getrssdetailsResponse is not a function

I tried to fix but to be honest I couldnt understand well what fails

@stickz
Copy link
Collaborator

stickz commented May 17, 2024

Hello, @fabricionaweb the testing code is a low priority for the ruTorrent project. We implemented it as a precautionary measure to test some of our more complex changes.

If you'd like to contribute to the ruTorrent project, we have quite a few outstanding tasks in the issues report section. Just ping @stickz and I'll help out the best I can. Everything has been clearly labeled for easy understanding and resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants