Make throttle an optional dependency for extratio #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickz
requested changes
Jun 30, 2024
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a conditional statement to check if the throttle plugin is installed, and to initialize the WebUI and adjust the http request accordingly.
There is one thing that's worth our notice, though. If we set up a rule that contains a throttle option, and disable the throttle plugin, and modify the rule setting again, and then enable the throttle plugin again, the original throttle option will be lost. It behaves this way because the PHP scripts take every submission of rule sets as creating new rules, instead of updating the existing ones.
With the throttle plugin installed
With the throttle plugin disabled
