Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply flex layout to tab bar #2712

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Apply flex layout to tab bar #2712

merged 6 commits into from
Sep 12, 2024

Conversation

jevenski
Copy link
Contributor

@jevenski jevenski commented Sep 7, 2024

  • Apply flex layout to the tab bar, and fix some display issues introduced in previous patches.
  • Adjusted different themes according to the new tab bar layout.

@stickz
Copy link
Collaborator

stickz commented Sep 7, 2024

Thanks @jevenski. This is progress which is good. I would like to improve this more in v5.1.

But for right now, there's a few basic fixes required to merge this pull request. Could we disable the text overflow?
ruTorrent_tabs_overflow

stickz
stickz requested changes Sep 7, 2024
View reviewed changes
js/common.js Outdated Show resolved Hide resolved
@stickz
Copy link
Collaborator

stickz commented Sep 7, 2024

I can not see any tabs on the material design theme when they overflow.
rutorrent_no_tabs_material_design

The tabs are only 25% visible on the oblivion theme when they overflow.
rutorrent_no_tabs_oblivion

jevenski and others added 4 commits September 12, 2024 13:12
@jevenski
Fix various styling issues
706122a 
- Fix scrollbar overlapping with tabs for MaterialDesign and Oblivion
  theme.
- Fix s-table table header cell d'n'd positioning issue.
- Fix rutracker_check plugin DOM structure to comply with other
  built-in items.
- Remove ancient browser version check code blocks for Konqueror.
@jevenski
Apply flex layout to traffic tab page
5d8257a
@stickz
Brighter MaterialDesign tab text
bfa4c6d
@stickz
Brighter Oblivion tab text
bbc7457
@stickz
Copy link
Collaborator

stickz commented Sep 12, 2024

Thanks @jevenski. I changed the color of the tab text on MaterialDesign and Oblivion for you to merge this PR faster. I selected a brighter gray to increase visibility on both desktop and mobile displays. Skipped the Dark themes since they are dark intentionally.

@stickz stickz merged commit d15e431 into Novik:develop Sep 12, 2024
@jevenski jevenski deleted the flex-tabs branch September 13, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stickz stickz stickz requested changes

Assignees
No one assigned
Labels
bug enhancement v4.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jevenski @stickz