Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply flex layout to various plugins #2715

Merged
merged 8 commits into from
Sep 24, 2024
Merged

Conversation

jevenski
Copy link
Contributor

  • Flex layout was applied to the following plugins: cookies, lookat, retrackers, uploadeta, extsearch, history. Most of the changes were done in the sense of option pages, except for the extsearch plugin that has an add torrent from search result dialog window as well.
  • Implement the connecting lines in the left-side navigation of the option window with CSS borders, and remove the previous background images. This could save a few bytes of bandwidth.

@jevenski
Copy link
Contributor Author

At the moment, there are only four plugins left to be rewritten for responsive UI: scheduler, channels, ragio groups, and screenshots.

@stickz
Copy link
Collaborator

stickz commented Sep 23, 2024

Looks good. I would like to request 2 minor changes before merge.

1) Checkbox and textbox on separate lines for desktop on unpack plugin.
ruTorrent_unpack_sep_lines

2) Retrackers to fit in the settings menu without scrolling on desktop.
ruTorrent_retrackers_no_scroll

@koblack
Copy link
Contributor

koblack commented Sep 23, 2024

Maybe we can do something like this?

unpack-after

@stickz
Copy link
Collaborator

stickz commented Sep 23, 2024

Maybe we can do something like this?

Yes agreed.

- Adjust the height of URL text boxes of Retrackers plugin, and width of the torrent label filter text box of Unpack plugin.
@stickz
Copy link
Collaborator

stickz commented Sep 24, 2024

Thanks @jevenski. Any chance in working on the remaining 4 plugins next?

I would like to tag ruTorrent v5.0 Beta 1 afterwards. Then get the changes distributed, so we can get development feedback coming in. We have enough stability and everything is better than it was on mobile. Tagging a release shortly, will allow us to more easily resolve any potential regressions. We can continue mobile development. This is just a milestone for our progress.

@stickz stickz merged commit 00dae2b into Novik:develop Sep 24, 2024
@jevenski jevenski deleted the flex-options branch September 25, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants