Rewrite _getdir plugin #2718
Merged
Rewrite _getdir plugin #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Combine getfiles.php and getdirs.php into one script listdir.php; - Return the directory list in JSON format and render it in an HTML `<dialog>` instead of returning server-rendered HTML and display it in an `<iframe>``; - Attach the directory list frame to the root node (actually a wrapper `#dir-container`), instead of the containing dialog window, so that the frame can grow outside the boundary of the dialog window and still show up properly. Otherwise, the directory list would be "clipped" when the height exceeds that of its containing window. The original Save To window used an invisible pad attached to the bottom to contain the extra height of the frame. In my previous flex layout patch, I increased the gap between the options so that the window would be high enough to contain the frame. Now the problem is solved. - Add a linkage to the directory list frame and its containing window for drap-n-drop movement, since the frame now don't belong to the containing window, it would not have moved automatically with the window. - Allow navigating through the directories using arrow keys: ArrowUP and ArrowDown for selecting, ArrowRight for entering the selected directory, ArrowLeft for going back to the parent directory, Home and End for going to the top and the end respectively; - Adapt the directory list frame to different themes.
- Fix scheduler table hour display and selection bugs. - Increase decimal digit edit input width for better mobile display.
stickz
requested changes
Sep 29, 2024
stickz
requested changes
Sep 29, 2024
If the trailing slash is excluded, we need to add it in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the heavy modifications made to upstream code, I made this new pull request based on the latest develop branch. Most of the features are the same as the original pull request, plus a few fixes for bugs that got their way in during the last few commits.
Plugin Features:
listdir.php;<dialog>instead of returning server-rendered HTML and display it in an `<iframe>``;#dir-container), instead of the containing dialog window, so that the frame can grow outside the boundary of the dialog window and still show up properly. Otherwise, the directory list would be "clipped" when the height exceeds that of its containing window. The original Save To window used an invisible pad attached to the bottom to contain the extra height of the frame. In my previous flex layout patch, I increased the gap between the options so that the window would be high enough to contain the frame. Now the problem is solved.ArrowUPandArrowDownfor selecting,ArrowRightfor entering the selected directory,ArrowLeftfor going back to the parent directory,HomeandEndfor going to the top and the end respectively;Original Pull Request: #2704