Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bug fixes for v5-beta1 #2722

Merged
merged 9 commits into from
Oct 4, 2024
Merged

Various bug fixes for v5-beta1 #2722

merged 9 commits into from
Oct 4, 2024

Conversation

jevenski
Copy link
Contributor

@jevenski jevenski commented Oct 2, 2024

Fix legend text overlapping by adding a non-transparent background to it. Apply some minor display adjustment for MaterialDesign theme as well.

Screenshot 2024-10-02 222117

- As well as some minor display adjustment for MaterialDesign theme.
- Replace verbose utility classes with plain CSS rules.
- Center any open dialogs when the WebUI resizes.
@jevenski
Copy link
Contributor Author

jevenski commented Oct 3, 2024

I mixed a few more bug fixes into this pull request, so we can speed up the code review process. Correct me if it's better practice to aim one target per pull request.
These new commits fixes the "Save" button on the spectrogram dialog and the create-torrent dialog. Old spectrogram save fix didn't get it right yet. The "Save" button was added every time we create a spectrogram, and it's still there after we close the dialog. So if we create 100 spectrograms, there will be 100 "Save" buttons. As for the create-torrent dialog, the "Save" button was added as visible, while it should be added as hidden.
In the utility classes clean-up commit, I added another action to center any open dialogs when the WebUI resizes. This could be useful when we switch between different display sizes when developing, or change device orientation when using ruTorrent in production.

@stickz stickz changed the title Prevent legend text overlapping Various bug fixes for v5-beta1 Oct 4, 2024
@stickz
Copy link
Collaborator

stickz commented Oct 4, 2024

Thanks!

@stickz stickz merged commit 5b51e12 into Novik:develop Oct 4, 2024
@jevenski jevenski deleted the feedback branch October 5, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants