MaterialDesign: update fonts #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm okay with this change to support different languages, but can we add all the resources to the ruTorrent project? There are multiple reasons why we load everything locally instead of from a third party source. |
|
I modified the pull request and added just more local fonts. In the case of English, the fonts had a total size of 186,523 bytes before the change and 125,328 bytes after the change, so they are now ~33% smaller. |
|
Thanks looks good. I'll verify it works tomorrow and merge if there are no problems. 125KB is great considering they don't load unless the material design theme is used. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local fonts used in MaterialDesign contain only the basic character set. This causes problems with displaying characters correctly in some languages e.g. Polish. ruTorrent has been translated into 27 languages. To display dialectal characters correctly in many different languages, we need fonts with the full character set.
Importing fonts allows us to dynamically load the diacritics when needed. Not everyone needs to download all of them. Also, instead of TTF the WOFF2 format with compression makes the fonts smaller.