Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase font size for mobile screens #2748

Closed
wants to merge 0 commits into from

Conversation

jevenski
Copy link
Contributor

  • Set font size to 16px for mobile, and 11px for desktop.
  • Adjust s-table's createRow() method to use jQuery to create table rows.
  • Adjust CPU load and disk space plugins styling for larger font size on mobile.
  • Adjust top menu and main content height for different screens.
  • Adjust some of the setting pages to better suit for the enlarged font size.

@stickz
Copy link
Collaborator

stickz commented Oct 20, 2024

Thanks @jevenski.

What you think about saving this PR for v5.2? If I merge this now, it will impact time and success of the v5.1 release. The scope of the change will take significant time and feedback to perfect.

@jevenski
Copy link
Contributor Author

Yeah, sure. We can leave this one to the next develop cycle. Coding and testing these changes cost 2 weeks, yet there are still some flaws in themes like Excel and Oblivions, and surely we'll need more time to review these changes.

@koblack
Copy link
Contributor

koblack commented Oct 21, 2024

Yes, it's a big change, let's test it properly for a longer period of time.
Wow, everything is so huge now :-)
A few windows are too big and don't fit on the screen.
Also, the context menu is too long and doesn't fit on the screen.
Some texts don't fit in text fields and buttons.
A few screenshots from me.

Screenshot_20241021_090744_Chrome
Screenshot_20241021_090905_Chrome
Screenshot_20241021_090915_Chrome
Screenshot_20241021_090925_Chrome
Screenshot_20241021_090934_Chrome
Screenshot_20241021_091025_Chrome
Screenshot_20241021_091054_Chrome

@jevenski
Copy link
Contributor Author

These are the remaining changes I intend to make.

  1. Rewrite the context menu for mobile, like adding a three-dot button to a table row when selected and clicking on the button to bring up the context menu. Also rewrite the context menu layout using the Flexbox system.
  2. In the settings window, shrink the left tree navigation to icons for mobile, and expand it when clicked on, so that we can have more room for the options on the right.
  3. Set the max-height for dialog windows and enable scrolling if the content height exceeds the window height. I thought I had done this before, but it probably got lost among all the branches. This is fairly simple to implement thought.

@stickz
Copy link
Collaborator

stickz commented Oct 21, 2024

These are the remaining changes I intend to make.

  1. Rewrite the context menu for mobile, like adding a three-dot button to a table row when selected and clicking on the button to bring up the context menu. Also rewrite the context menu layout using the Flexbox system.
  2. In the settings window, shrink the left tree navigation to icons for mobile, and expand it when clicked on, so that we can have more room for the options on the right.
  3. Set the max-height for dialog windows and enable scrolling if the content height exceeds the window height. I thought I had done this before, but it probably got lost among all the branches. This is fairly simple to implement thought.

What do you think about creating roadmap for v5.2 like the one I made for v5.1? I would like to add some things to v5.2 like reducing clutter on the context menu. #2740

Also are we making any process on the v5.1 roadmap? I can change it if required. I'd like to get this release closed and thousands of people converted to the version 5 branch with the v5.1 release; so they can provide feedback on our changes.

@stickz stickz added the v5.2 label Oct 21, 2024
@jevenski
Copy link
Contributor Author

jevenski commented Oct 21, 2024

I've got started working on this one: #2734 It requires some change to the button's HTML structure, so it needs some fine tunings. Also I'm getting occupied with reallife work, so I have spent less time over the last weeks on coding ruTorrent than before.

The changes mentioned above are ones currently on my mind for v5.2. Besides, there are a few ideas that would not be so noticable to users, but only to developers. I've been doing so in the last few commits and will try my best to do so in the future, but there is still a long way to go.

  1. I'm planning to clean up the CSS files. That is to say, define all color related styling rules using variables, and thus we only need to redefine different color palettes in different themes. Most other layout related CSS rules can be reused from the main CSS file. This way the themes can become easier to maintain and more error proof.

  2. Add documentations for all the classes and functions, so that ruTorrent can become more developer friendly. As the documentations may bloat the size of the entire project, we can probably minify the js files when publishing a release package in order to save bandwidth for non-developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants