Prevent collapse menu from pushing content down #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On mobile, an open top menu will now go above the main content, instead of pushing the main content downward. This will prevent resizing issues. - Remove some unused CSS rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch tweaks the behavior of the top menu when it expands and collapse.
Before
After
Currently on mobile, when opening the top menu, the main content will be pushed downwards. See how the "Name" header row goes downwards and upwards with the top menu when it expands and collapses. This creates resizing issues on mobile devices sometimes. Fix the position of main content and make top menu go above it looks more consistent on the overall layout.
Also, I try to reduce the specificity of CSS rules step by step, to make them cleaner and easier to maintain. Here in this patch, there are a few lines modified, too.