Use CSS to indicate the importance of whitespace rather than replacing with nbsp's #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g with nbsp's Closes Novik#2779 Alternate fix for Novik#2757 Partially reverts Novik#2768
|
Don't merge this yet, more problems being investigated. Update: I've needed to pause my effort on this for the moment to focus on other projects. This patch has fixed a subset of the issues, but other creations involving spaces are still failing. Torrents created with 0 files in them, and I haven't figured out the cause yet. |
|
Re-opening. I believe this is functionally correct. But there's also a separate, unrelated issue with creating torrents from a single file with spaces in the name that still needs more investigation. This pull request fixes whitespace in all directories that are being used for torrent creation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration, a CSS-only fix for the whitespace disappearing problem.
Closes #2779
Alternate fix for #2757
Partially reverts #2768