Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fixes for DarkBetter theme icons #2822

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

jevenski
Copy link
Contributor

This is a backport of typo fixes from this pull request: #2821

@stickz
Copy link
Collaborator

stickz commented Dec 11, 2024

@jevenski Are any of these items removed still used in v5.1? I just need to confirm before merging this.

@jevenski
Copy link
Contributor Author

Only duplicated icon links were removed and a typo was fixed in this PR. No extra items removed.

@stickz
Copy link
Collaborator

stickz commented Dec 11, 2024

Great thanks! Can this fix be backported to branch v4.3 super stable as well?

@stickz stickz merged commit d70bda8 into Novik:master Dec 11, 2024
@jevenski
Copy link
Contributor Author

Great thanks! Can this fix be backported to branch v4.3 super stable as well?

@stickz I think this patch can be directly cherry-picked onto v4.3 branch without conflict. This part hasn't been modified yet since v4.3. If a pull request is in need, I can file one later.

@jevenski jevenski deleted the typo-fix branch December 11, 2024 15:13
@stickz
Copy link
Collaborator

stickz commented Dec 11, 2024

Great thanks! Can this fix be backported to branch v4.3 super stable as well?

@stickz I think this patch can be directly cherry-picked onto v4.3 branch without conflict. This part hasn't been modified yet since v4.3. If a pull request is in need, I can file one later.

Cherry picked! Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants