Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolchain): start writing AST printers #266

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Conversation

NoxHarmonium
Copy link
Owner

  • This will be handy in the future for creating an opinionated formatter, but for now I just implemented the data part of the AST so that the tiledit program can use it to print out assembly generated from image data
  • Did a massive refactor to make it so the parsers and the printers both depend on shared types but aren't coupled to each other
  • Fixed an annoying bug where whitespace at the end of the file could cause the parser to fail

- This will be handy in the future for creating an opinionated formatter, but for now I just implemented the data part of the AST so that the tiledit program can use it to print out assembly generated from image data
- Did a massive refactor to make it so the parsers and the printers both depend on shared types but aren't coupled to each other
- Fixed an annoying bug where whitespace at the end of the file could cause the parser to fail
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 80.75117% with 41 lines in your changes missing coverage. Please review.

Project coverage is 66.05%. Comparing base (0c5099b) to head (0f452cf).

Files Patch % Lines
sirc-vm/toolchain/src/parsers/shared.rs 85.29% 8 Missing and 2 partials ⚠️
sirc-vm/toolchain/src/parsers/data.rs 84.48% 7 Missing and 2 partials ⚠️
sirc-vm/toolchain/src/printers/data.rs 66.66% 9 Missing ⚠️
sirc-vm/toolchain/src/parsers/instruction.rs 76.00% 6 Missing ⚠️
sirc-vm/toolchain/src/printers/shared.rs 83.33% 5 Missing ⚠️
sirc-vm/toolchain/src/data/object.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   65.85%   66.05%   +0.19%     
==========================================
  Files          61       63       +2     
  Lines        5937     6018      +81     
  Branches     5686     5767      +81     
==========================================
+ Hits         3910     3975      +65     
- Misses       1873     1891      +18     
+ Partials      154      152       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NoxHarmonium NoxHarmonium merged commit 6553e38 into main Jul 1, 2024
13 checks passed
@NoxHarmonium NoxHarmonium deleted the toolchain-printer branch July 1, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant