Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add file content tests #201

Merged
merged 7 commits into from
Jul 11, 2023
Merged

Feature/add file content tests #201

merged 7 commits into from
Jul 11, 2023

Conversation

ILoveMyTortoise
Copy link
Contributor

No description provided.

@ILoveMyTortoise ILoveMyTortoise self-assigned this Jul 10, 2023
This was linked to issues Jul 10, 2023
Introduce code generator test by file content #182
Closed
Add additional test for validation of entity 'keys' #195
Closed
rochar
rochar approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@rochar rochar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, not sure if we went to far, time will tell :)

just review my single comment

src/Nox.EntityFramework.Postgres/PostgresDatabaseProvider.cs Outdated Show resolved Hide resolved
@rochar rochar merged commit c175e31 into main Jul 11, 2023
@rochar rochar deleted the feature/add-file-content-tests branch July 11, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochar rochar rochar approved these changes

Assignees

@ILoveMyTortoise ILoveMyTortoise

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add additional test for validation of entity 'keys' Introduce code generator test by file content
2 participants
@ILoveMyTortoise @rochar