Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types url #251

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Types url #251

merged 4 commits into from
Jul 17, 2023

Conversation

fkucuk
Copy link
Contributor

@fkucuk fkucuk commented Jul 17, 2023

No description provided.

@fkucuk
Url Type Implemented
671ce15 
- Url Type
- Types Tests
- EF Convertes
- EF Tests
- Percentage tests modified, 'cause were not working on Turkish decimal environment
@fkucuk
Merge branch 'main' into types-url
b978866
andresharpe
andresharpe approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@andresharpe andresharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Please fix merge errors but happy with implementation

@fkucuk fkucuk merged commit 63ad29a into main Jul 17, 2023
@fkucuk fkucuk deleted the types-url branch July 17, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandervlasenko alexandervlasenko alexandervlasenko approved these changes

@rochar rochar rochar approved these changes

@andresharpe andresharpe andresharpe approved these changes

@gjorgji-grgovski-authoritypartners gjorgji-grgovski-authoritypartners Awaiting requested review from gjorgji-grgovski-authoritypartners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fkucuk @andresharpe @rochar @alexandervlasenko