Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/nox.type.abstractions #259

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Feature/nox.type.abstractions #259

merged 5 commits into from
Jul 18, 2023

Conversation

andresharpe
Copy link
Contributor

Refactored the current main branch :-

  • Nox.Types.Abstractions (netstandard 2.0) - contains all TypeOptions but no type implementations, also all schema attributes
  • Nox.Types (net7) - depends on Nox.Types.Abstractions
  • Nox.Solution - depends on Nox.Types.Abstractions
  • Nox.Generator - depends on Nox.Solution that depends on Nox.Types.Abstractions
  • All tests pass (except the broken Secrets ones)
  • Will allow implementation of NoxTypes in modern .NET (7/8) and keep the generator healthy.
  • I'll push the branch for review and discussion?

@andresharpe andresharpe marked this pull request as draft July 17, 2023 15:48
rochar
rochar approved these changes Jul 17, 2023
View reviewed changes
src/Nox.Types.Abstractions/Attributes/Shema/AdditionalPropertiesAttribute.cs Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo on the Folder containing this attributes

src/Nox.Types.Abstractions/Nox.Types.Abstractions.csproj
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the package configuration and treat warning as errors

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add add the nox image

@andresharpe andresharpe marked this pull request as ready for review July 18, 2023 07:06
@jan-schutte jan-schutte merged commit 88b7a56 into main Jul 18, 2023
@jan-schutte jan-schutte deleted the feature/Nox.Type.Abstractions branch July 18, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-schutte jan-schutte jan-schutte approved these changes

@rochar rochar rochar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresharpe @rochar @jan-schutte