Skip to content

Commit

Permalink
Address Andy's comment
Browse files Browse the repository at this point in the history
  • Loading branch information
erdembayar committed Dec 19, 2022
1 parent 148c65f commit 72bcb2c
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions proposed/2022/PrivateAssetIndepdentFromExcludeAsset.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,9 @@ We already have a [logic](hhttps://github.com/NuGet/NuGet.Client/blob/380415d812

- Alternatively we could make it opt-in option as metadata on the PackageReference item, but most likely customers'll be planning on opting entire project/repos into this setting rather than try to make sense of specific references having different behavior.
If we do keep it as item metadata, will it be harmless to add that metadata to all PackageReference items, such that we can add it to an ItemDefinition group so we can get the desired behavior everywhere, although we don't specify some of the other attributes like PrivateAssets or IncludeAssets on every PackageReference item.
`<PackageReference Include="Microsoft.Windows.CsWin32" Version="0.2.138-beta" IncludeAssets="build" PrivateAssetIndependent="true" />`

- Also we could add yet another tag like `TransitiveAssets` or `ExcludeTransitiveAssets` to same existing `IncludeAssets/ExcludeAssets/PrivateAssets` tags, only difference is to control transitive asset flow. Technically it overlaps more with `PrivateAssets` in functionality, most likely we don't need `PrivateAssets` anymore if the new tag is introduced.
`<PackageReference Include="Microsoft.Windows.CsWin32" Version="0.2.138-beta" IncludeAssets="build" ExcludeTransitiveAssets="none" />`

## Prior Art
Expand Down

0 comments on commit 72bcb2c

Please sign in to comment.