Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NuGet.PackageManagement: Solution folder corresponding to 'Scripts' folder of jQuery.2.1.3 alone does not get removed, on an uninstall #225

Closed
deepakaravindr opened this issue Mar 16, 2015 · 1 comment
Closed

NuGet.PackageManagement: Solution folder corresponding to 'Scripts' folder of jQuery.2.1.3 alone does not get removed, on an uninstall #225

deepakaravindr opened this issue Mar 16, 2015 · 1 comment
Assignees
@yishaigalatzer
Labels
Functionality:SDK The NuGet client packages published to nuget.org Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug
Milestone
3.3.0

Comments

@deepakaravindr
Copy link

NuGet.PackageManagement: Solution folder corresponding to 'Scripts' folder of jQuery.2.1.3 alone does not get removed, on an uninstall
@deepakaravindr deepakaravindr added Functionality:SDK The NuGet client packages published to nuget.org Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug labels Mar 16, 2015
@deepakaravindr deepakaravindr self-assigned this Mar 16, 2015
@deepakaravindr deepakaravindr modified the milestones: 3.0.0-rc, 3.0.0-rc2 Mar 16, 2015
@ChrisSfanos ChrisSfanos modified the milestones: 3.0.0-rc2, 3.0.0-RTM Apr 9, 2015
@AndriySvyryd
Copy link
Member

Scripts\jquery-2.1.3.intellisense.js file is removed by uninstall.ps1 and thus the removal of the Scripts folder should be handled there as well

@deepakaravindr deepakaravindr modified the milestones: 3.3.0-Beta, 3.0.0-RTM Oct 12, 2015
yishaigalatzer pushed a commit to NuGet/NuGet.Client that referenced this issue Oct 12, 2015
Fix NuGet/Home#225
067d6c5 
Fix NuGet/Home#1547

1. Change the order of uninstall to run the uninstall.ps1 script first (to match NuGet 2)
2. Check that the folder exists before trying to delete it
3. Remove duplicate call to Remove file from the project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yishaigalatzer yishaigalatzer

Labels
Functionality:SDK The NuGet client packages published to nuget.org Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
4 participants
@yishaigalatzer @ChrisSfanos @deepakaravindr @AndriySvyryd