Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write out targets/props files on failed restore #3399

Closed
jainaashish opened this issue Sep 1, 2016 · 3 comments
Closed

Write out targets/props files on failed restore #3399

jainaashish opened this issue Sep 1, 2016 · 3 comments

Comments

@jainaashish
Copy link
Contributor

Today we don't write *.nuget.targets and *.nuget.props files when a restore fails but could give some confusing errors to the users for .net core projects. So we should write these files irrespective of restore failed or succeed.

@rrelyea rrelyea added this to the 3.6 Beta1 milestone Sep 6, 2016
@rrelyea rrelyea modified the milestones: 3.6 Beta1, 3.6 Beta2, 3.6 RC Sep 22, 2016
@rrelyea
Copy link
Contributor

rrelyea commented Dec 13, 2016

@emgarten - did this already get fixed in 4.0?

@emgarten emgarten assigned emgarten and unassigned jainaashish Dec 14, 2016
@emgarten emgarten modified the milestones: 4.0 RC3, Future-1 Dec 14, 2016
@emgarten
Copy link
Member

@rrelyea I think so, if not I'll make sure we do along with the content files change with tests.

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Dec 16, 2016
Fixes NuGet/Home#4098
Fixes NuGet/Home#3928
Fixes NuGet/Home#3683
Fixes NuGet/Home#4098
Fixes NuGet/Home#3399

Adding tests to verify files are written out on failure
@emgarten
Copy link
Member

Related to #4116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants