Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution Restore should clear AutoRestore queue and be added to queue, preventing hangs #3816

Closed
rrelyea opened this issue Oct 28, 2016 · 1 comment
Closed

Solution Restore should clear AutoRestore queue and be added to queue, preventing hangs #3816

rrelyea opened this issue Oct 28, 2016 · 1 comment
Assignees
@alpaix
Labels
Functionality:Restore Platform:Xplat Style:PackageReference Type:DCR Design Change Request
Milestone
Future-0

Comments

@rrelyea
Copy link
Contributor

rrelyea commented Oct 28, 2016

No description provided.

@rrelyea rrelyea added this to the 4.0 RC2 milestone Oct 28, 2016
@rrelyea rrelyea mentioned this issue Oct 28, 2016
Closed
alpaix added a commit to alpaix/NuGet.Client that referenced this issue Nov 1, 2016
@alpaix
[WIP] Block Solution Restore if auto restore is running
72aee95 
Resolves NuGet/Home#3816.

Added `IsBusy` attribute to evaluate active restore operation is
in-progress.

Refactored restore operation implementation to use `JoinableTask` when
chaining subsequent operations. This technique is supposed to prevent
deadlocks we were seeing lately.
@rrelyea rrelyea modified the milestones: 4.0 RC2, 4.0 RC3 Nov 29, 2016
@rrelyea rrelyea modified the milestones: 4.0 RTM, 4.0 RC3 Jan 4, 2017
@alpaix alpaix mentioned this issue Jan 11, 2017
Closed
@rrelyea rrelyea changed the title Solution Restore should clear AutoRestore queue and be added to queue. Solution Restore should clear AutoRestore queue and be added to queue, preventing hangs Jan 19, 2017
@rrelyea rrelyea modified the milestones: 4.0.1, 4.0 RTM Jan 31, 2017
@rrelyea
Copy link
Contributor Author

rrelyea commented Jan 31, 2017

would prefer to do in 4.0, but will be focusing on higher hitters.

@alpaix alpaix added the Type:DCR Design Change Request label Feb 14, 2017
@alpaix alpaix mentioned this issue Feb 17, 2017
Closed
alpaix added a commit to alpaix/NuGet.Client that referenced this issue Feb 28, 2017
@alpaix
Solution Restore should run in background
69f4f3f 
Resolves NuGet/Home#3816.
Resolves NuGet/Home#4255.
Resolves NuGet/Home#4636.

In order to prevent hangs in VS Solution Restore should create a background task and push it in the restore worker queue.

Added E2E test suite for .NET Standard multi-targeting class library
@alpaix alpaix mentioned this issue Feb 28, 2017
Merged
alpaix added a commit to alpaix/NuGet.Client that referenced this issue Mar 1, 2017
@alpaix
Solution Restore should run in background
53d21c1 
Resolves NuGet/Home#3816.
Resolves NuGet/Home#4255.
Resolves NuGet/Home#4636.

In order to prevent hangs in VS Solution Restore should create a background task and push it in the restore worker queue.

Added E2E test suite for .NET Standard multi-targeting class library
alpaix added a commit to NuGet/NuGet.Client that referenced this issue Mar 1, 2017
@alpaix
Solution Restore should run in background
77fe4c0 
Resolves NuGet/Home#3816.
Resolves NuGet/Home#4255.
Resolves NuGet/Home#4636.

In order to prevent hangs in VS Solution Restore should create a background task and push it in the restore worker queue.

Added E2E test suite for .NET Standard multi-targeting class library
alpaix added a commit to NuGet/NuGet.Client that referenced this issue Mar 2, 2017
@alpaix
Solution Restore should run in background
8fc646c 
Resolves NuGet/Home#3816.
Resolves NuGet/Home#4255.
Resolves NuGet/Home#4636.

In order to prevent hangs in VS Solution Restore should create a background task and push it in the restore worker queue.

Added E2E test suite for .NET Standard multi-targeting class library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alpaix alpaix

Labels
Functionality:Restore Platform:Xplat Style:PackageReference Type:DCR Design Change Request
Projects
None yet
Milestone
Future-0
Development

No branches or pull requests
2 participants
@alpaix @rrelyea