Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename values of _ProjectRestoreType property #4047

Closed
dsplaisted opened this issue Dec 1, 2016 · 2 comments
Closed

Rename values of _ProjectRestoreType property #4047

dsplaisted opened this issue Dec 1, 2016 · 2 comments

Comments

@dsplaisted
Copy link

NuGet.targets sets the value of the _ProjectRestoreType property based on how package references are expressed. However, the values of the property currently refer to what the project is targeting, which may not correspond to how package references are expressed. For example, it's possible to use PackageReference with .NET Framework projects, but the value of _PackageRestoreType would be NETCore.

So I suggest considering changing UAP to ProjectJson and NETCore to PackageReference.

@emgarten
Copy link
Member

emgarten commented Dec 6, 2016

@dsplaisted what scenarios are you relying on this internal property for?

The work to expose this publicly is in progress and being tracked here: #3928 ProjectJson and PackageReference are the two possible values so far.

@dsplaisted
Copy link
Author

See #4046. In the .NET SDK, we want the project restore type to be .NET Core, even if there aren't any PackageReferences in the project, so that we get the transitive package references from referenced projects. Right now we do this by injecting a target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants