Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename OutputType to ProjectStyle #1067

Closed
wants to merge 5 commits into from
Closed

Conversation

emgarten
Copy link
Member

@emgarten emgarten commented Dec 20, 2016

This is primarily a big find and replace and the addition of a public property to set the restore type.

In MSBuild the restore type can now be set externally:
_ProjectRestoreType -> RestoreProjectType

Other renames:
OutputType -> ProjectStyle
NETCore -> PackageReference
UAP -> ProjectJson

Fixes NuGet/Home#4047
Fixes NuGet/Home#4046
Fixes NuGet/Home#3504

//cc @alpaix @mishra14 @rohit21agrawal @nkolev92 @jainaashish

Copy link
Contributor

@mishra14 mishra14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the comment, and then :shipit:

},
'frameworks': {
'net45': {
'y': '1.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 'x':'1.0.0'?
Or is this a preexisting dependency for the project?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update it

@emgarten emgarten closed this Dec 20, 2016
@emgarten emgarten deleted the dev-emgarten-projectStyle2 branch December 20, 2016 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants