Is there a way to mute NU1603?

[forki]

On Windows (I haven't tested this on macOS or Linux)

1. Install .NET Core 2.0.2

2. Clone fable-suave-scaffold

3. Instal Node LTS and Yarn latest

4. Run build.cmd

Expected behaviour

No NU1603 since paket controls the dependencies

Actual behaviour

[emgarten]

<NoWarn>$(NoWarn);NU1603</NoWarn> will turn off the warning

https://blog.nuget.org/20170815/Whats-nu-in-NuGet-with-VS2017-15-3.html
https://github.com/NuGet/Home/wiki/Improved-NuGet-warnings

[forki]

is that something we can set in nuget.config? Or ar least when we add PackageReferences in memory?

[emgarten]

NoWarn is only read from the project file currently.

https://github.com/NuGet/NuGet.Client/blob/012941024a48a22bdcaf9fa3171276e7c075630e/src/NuGet.Core/NuGet.Build.Tasks/NuGet.targets#L599

[forki]

ok but setting it in Paket.Restore.targets should work as well, right?

[emgarten]

Should work if you can set it before it is read. Let me know if it doesn't and we can find a different way.

[forki]

urgs. now other tools (in this case F# compiler) complain about that

/cc @dsyme @KevinRansom @cartermp

[emgarten]

Gah! Seems like we should test these on all project types going forward.

The design for this was to use the exact same fields as the compiler so that users could add these through the project properties window.

[forki]

ok reverting that for now. We need another solution. If people are using warnaserror in F# then things will crash.

[emgarten]

Alternatively you could set HideWarningsAndErrors to true and then replay them after restore from project.assets.json with filtering. It would be much more work than just setting nowarn however.

[forki]

O_o

[forki]

sorry, what I meant is: NuGet's current approach is not working with F# and that has nothing to do with paket. If you set the NoWarn in the project then the compiler will scream at you.

[mishra14]

Closing this issue in the favor of dotnet/fsharp#3626.

Please feel free to reopen this if you feel otherwise.

[forki]

It's still problematic to reuse compiler features. But that's maybe just my personal opinion. Am 22.09.2017 20:28 schrieb "Ankit Mishra" <notifications@github.com>:

…

Closing this issue in the favor of dotnet/fsharp#3626 <dotnet/fsharp#3626>. Please feel free to reopen this if you feel otherwise. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5913 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNOL9crzl5P7-TYPLE2fZhhP-b1Ceks5sk_xbgaJpZM4Pe26j> .

[rrelyea]

@forki - Hear ya. We should have communicated with more compilers than we did during 15.3. Sorry that we didn't.

[KevinRansom]

@rrelyea
I believe this design makes use of a bug in the C# compiler. It ignores anything it doesn't understand ... and it only understands numeric values. I doubt if the bug will ever get fixed though.

You should consider changing the name of the msbuild property from NoWarn to NugetNoWarn or NoWarnNuget.

Kevin

The C# bug:

namespace ConsoleApp10 {
    class Program {
        static void Main(string[] args) {
            int x = 7;
        }
    }
}

csc Program.cs

Microsoft (R) Visual C# Compiler version 2.3.2.62019 (b7354608)
Copyright (C) Microsoft Corporation. All rights reserved.

Program.cs(13,17): warning CS0219: The variable 'x' is assigned but its value is never used

csc Program.cs /nowarn:0219

Microsoft (R) Visual C# Compiler version 2.3.2.62019 (b7354608)
Copyright (C) Microsoft Corporation. All rights reserved.

now this:
csc Program.cs /nowarn:cs0219

Microsoft (R) Visual C# Compiler version 2.3.2.62019 (b7354608)
Copyright (C) Microsoft Corporation. All rights reserved.

Program.cs(13,17): warning CS0219: The variable 'x' is assigned but its value is never used

C# ignores any non numeric value including cs0219. It is a C# bug, and it is very likely it won't get fixed.

[mishra14]

@KevinRansom Thanks for the detailed response.

I have one correction - /nowarn:CS0219 works as expected -

F:\validation\test\addpkg>csc Program.cs  /nowarn:CS0219
Microsoft (R) Visual C# Compiler version 2.4.0.62025 (a0507c1e)
Copyright (C) Microsoft Corporation. All rights reserved.


F:\validation\test\addpkg>csc Program.cs  /nowarn:cs0219
Microsoft (R) Visual C# Compiler version 2.4.0.62025 (a0507c1e)
Copyright (C) Microsoft Corporation. All rights reserved.

Program.cs(9,17): warning CS0219: The variable 'x' is assigned but its value is never used

F:\validation\test\addpkg>

Note that it is case sensitive, so cs0219 is not the same as CS0219.

[KevinRansom]

Really capital CS works? That’s interesting … I guess I should add it to the compiler in that case. @rrelyea apparently it is case sensitive ... so I will update the compiler to accept FS and ignore other stuff.