Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net5.0-platform test failures #9682

Closed
zkat opened this issue Jun 15, 2020 · 0 comments · Fixed by NuGet/NuGet.Client#3479
Closed

net5.0-platform test failures #9682

zkat opened this issue Jun 15, 2020 · 0 comments · Fixed by NuGet/NuGet.Client#3479
Assignees
@zkat
Labels
Functionality:Pack Partner:DotNet Priority:1 High priority issues that must be resolved in the current sprint. Product:dotnet.exe Product:NuGet.exe NuGet.exe RegressionDuringThisVersion A regression which broke since last RTM, and was fixed before the next RTM. Type:Bug
Milestone
Sprint 173 - 2020...

Comments

@zkat
Copy link
Contributor

zkat commented Jun 15, 2020

Looks like I may have been overly optimistic about the nature of my net5.0-platform change. dotnet's own tests found a bug in our pack code caused by the current platform changes. Pack will likely need to be updated, and possibly, we may need to re-evaluate the way we're handling net5.0 TFM formats, though I hope it doesn't come to that.

cc @aortiz-msft @nkolev92
@zkat zkat added Priority:1 High priority issues that must be resolved in the current sprint. Type:Bug Product:NuGet.exe NuGet.exe Functionality:Pack Product:dotnet.exe RegressionDuringThisVersion A regression which broke since last RTM, and was fixed before the next RTM. Partner:DotNet labels Jun 15, 2020
@zkat zkat added this to the Sprint 172 - 2020.06.15 milestone Jun 15, 2020
@zkat zkat self-assigned this Jun 15, 2020
This was referenced Jun 15, 2020
Merged
Closed
@sfoslund sfoslund mentioned this issue Jun 25, 2020
Closed
@zkat zkat mentioned this issue Jun 29, 2020
Merged
zkat added a commit to NuGet/NuGet.Client that referenced this issue Jul 3, 2020
@zkat
add support for net5.0-<platform>
6e1356b 
Fixes: NuGet/Home#9682
zkat added a commit to NuGet/NuGet.Client that referenced this issue Jul 10, 2020
@zkat
net5.0-platform support (#3479)
1f12139 
Fixes: NuGet/Home#9682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zkat zkat

Labels
Functionality:Pack Partner:DotNet Priority:1 High priority issues that must be resolved in the current sprint. Product:dotnet.exe Product:NuGet.exe NuGet.exe RegressionDuringThisVersion A regression which broke since last RTM, and was fixed before the next RTM. Type:Bug
Projects
None yet
Milestone
Sprint 173 - 2020.07.06
Development

Successfully merging a pull request may close this issue.

net5.0-platform support for Pack NuGet/NuGet.Client
1 participant
@zkat