Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet features should light up for projects that have the capability; "PackageReferences" #9957

Closed
davkean opened this issue Aug 31, 2020 · 0 comments · Fixed by NuGet/NuGet.Client#3618
Assignees
Labels
Functionality:Restore Priority:2 Issues for the current backlog. Product:VS.Client Type:DCR Design Change Request

Comments

@davkean
Copy link

davkean commented Aug 31, 2020

This is a superset of #9358.

As part of dotnet/project-system#2491, we're adding general purpose PackageReference support to the Common Project System (CPS). Project types will opt into this feature by making sure they are marked with the "PackageReferences" capability.

Currently NuGet has a hard-coded set of project types which breaks the goal of having a project type just opt into this. NuGet can continue to consult the SupportedProjectType.IsSupported for existing project types, but if that fails, fall back to doing a hierarchy.IsCapabilityMatch("PackageReferences") for projects that fail that test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Restore Priority:2 Issues for the current backlog. Product:VS.Client Type:DCR Design Change Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants