Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec proposal for opt-in feature where PrivateAssets flag option indepdent from IncludeAssets/ExcludeAssets options #12313

Closed
wants to merge 37 commits into from
Closed

Spec proposal for opt-in feature where PrivateAssets flag option indepdent from IncludeAssets/ExcludeAssets options #12313

wants to merge 37 commits into from

Commits on Dec 7, 2022

  1. Spec proposal for privateAssets not eclipsed by includeassets/exclude… 

    …assets
    @erdembayar
    erdembayar committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    0864d28 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Improve example

    @erdembayar
    erdembayar committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5cd02a1 View commit details
    Browse the repository at this point in the history

  2. Address PR comment

    @erdembayar
    erdembayar committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    19bd26e View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Rename property to PrivateAssetIndependent

    @erdembayar
    erdembayar committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    58f030a View commit details
    Browse the repository at this point in the history

  2. Add project2project scenario

    @erdembayar
    erdembayar committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    d231ef3 View commit details
    Browse the repository at this point in the history

  3. Take Andy's suggestion

    @erdembayar
    erdembayar committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    b272b0e View commit details
    Browse the repository at this point in the history

  4. Clarify flow table

    @erdembayar
    erdembayar committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    fdf8ee8 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. P2P consumption example

    @erdembayar
    erdembayar committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    bf84bb4 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Update proposed/2022/PrivateAssetIndepdentFromExcludeAsset.md 

    Co-authored-by: Andrew Arnott <andrewarnott@gmail.com>
    @erdembayar @AArnott
    erdembayar and AArnott committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ed3370b View commit details
    Browse the repository at this point in the history

  2. Update proposed/2022/PrivateAssetIndepdentFromExcludeAsset.md 

    Co-authored-by: Andrew Arnott <andrewarnott@gmail.com>
    @erdembayar @AArnott
    erdembayar and AArnott committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    188b8dc View commit details
    Browse the repository at this point in the history

  3. Update proposed/2022/PrivateAssetIndepdentFromExcludeAsset.md 

    Co-authored-by: Andrew Arnott <andrewarnott@gmail.com>
    @erdembayar @AArnott
    erdembayar and AArnott committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6bf5644 View commit details
    Browse the repository at this point in the history

  4. Update proposed/2022/PrivateAssetIndepdentFromExcludeAsset.md 

    Co-authored-by: Andrew Arnott <andrewarnott@gmail.com>
    @erdembayar @AArnott
    erdembayar and AArnott committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    9563247 View commit details
    Browse the repository at this point in the history

  5. Update proposed/2022/PrivateAssetIndepdentFromExcludeAsset.md 

    Co-authored-by: Andrew Arnott <andrewarnott@gmail.com>
    @erdembayar @AArnott
    erdembayar and AArnott committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    68f52a1 View commit details
    Browse the repository at this point in the history

  6. Update proposed/2022/PrivateAssetIndepdentFromExcludeAsset.md 

    Co-authored-by: Andrew Arnott <andrewarnott@gmail.com>
    @erdembayar @AArnott
    erdembayar and AArnott committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    4cd21af View commit details
    Browse the repository at this point in the history

  7. Update proposed/2022/PrivateAssetIndepdentFromExcludeAsset.md 

    Co-authored-by: Andrew Arnott <andrewarnott@gmail.com>
    @erdembayar @AArnott
    erdembayar and AArnott committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a1f9f46 View commit details
    Browse the repository at this point in the history

  8. Update proposed/2022/PrivateAssetIndepdentFromExcludeAsset.md 

    Co-authored-by: Andrew Arnott <andrewarnott@gmail.com>
    @erdembayar @AArnott
    erdembayar and AArnott committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    3338e2c View commit details
    Browse the repository at this point in the history

  9. Take AArnott suggestion

    @erdembayar
    erdembayar committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    dae50f7 View commit details
    Browse the repository at this point in the history

  10. Address Fernando's comment

    @erdembayar
    erdembayar committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    c76de07 View commit details
    Browse the repository at this point in the history

  11. Correct pack example

    @erdembayar
    erdembayar committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    e9a8465 View commit details
    Browse the repository at this point in the history

  12. Add Alternative idea

    @erdembayar
    erdembayar committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    148c65f View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Address Andy's comment

    @erdembayar
    erdembayar committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    72bcb2c View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Rename property

    @erdembayar
    erdembayar committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    2b37bc5 View commit details
    Browse the repository at this point in the history

  2. Add example

    @erdembayar
    erdembayar committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    271e53b View commit details
    Browse the repository at this point in the history

  3. Address Nikolche's comments

    @erdembayar
    erdembayar committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    1f7b433 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. PublicAssets control

    @erdembayar
    erdembayar committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    001fad0 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Change to ExcludedAssetsFlow boolean metadata

    @erdembayar
    erdembayar committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    a36b5f0 View commit details
    Browse the repository at this point in the history

  2. Update proposed/2022/PrivateAssetIndepdentFromExcludeAsset.md 

    Co-authored-by: Andrew Arnott <andrewarnott@gmail.com>
    @erdembayar @AArnott
    erdembayar and AArnott committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    e24fbf5 View commit details
    Browse the repository at this point in the history

  3. Update proposed/2022/PrivateAssetIndepdentFromExcludeAsset.md 

    Co-authored-by: Andrew Arnott <andrewarnott@gmail.com>
    @erdembayar @AArnott
    erdembayar and AArnott committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    3db6950 View commit details
    Browse the repository at this point in the history

  4. Update proposed/2022/PrivateAssetIndepdentFromExcludeAsset.md 

    Co-authored-by: Andrew Arnott <andrewarnott@gmail.com>
    @erdembayar @AArnott
    erdembayar and AArnott committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    7311350 View commit details
    Browse the repository at this point in the history

  5. Address remaining comment by Andrew

    @erdembayar
    erdembayar committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    8fef1e9 View commit details
    Browse the repository at this point in the history

  6. Correct typos

    @erdembayar
    erdembayar committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    1d3d357 View commit details
    Browse the repository at this point in the history

  7. Address remaining comments by Nikolche

    @erdembayar
    erdembayar committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    c9b9bc1 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Update proposed/2022/PrivateAssetIndepdentFromExcludeAsset.md 

    Co-authored-by: Nikolche Kolev <nikolce1kolev@gmail.com>
    @erdembayar @nkolev92
    erdembayar and nkolev92 committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    df9cca9 View commit details
    Browse the repository at this point in the history

  2. Nikolche shorten comment

    @erdembayar
    erdembayar committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    0f4b052 View commit details
    Browse the repository at this point in the history

  3. Update proposed/2022/PrivateAssetIndepdentFromExcludeAsset.md 

    Co-authored-by: Nikolche Kolev <nikolce1kolev@gmail.com>
    @erdembayar @nkolev92
    erdembayar and nkolev92 committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    8693e02 View commit details
    Browse the repository at this point in the history

  4. Other comments

    @erdembayar
    erdembayar committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    0d53d37 View commit details
    Browse the repository at this point in the history

  5. More feedback address

    @erdembayar
    erdembayar committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    1af7f27 View commit details
    Browse the repository at this point in the history