Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec: NuGet onboarding to Unified Settings in Visual Studio #13561

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Spec: NuGet onboarding to Unified Settings in Visual Studio #13561

merged 6 commits into from
Dec 3, 2024

Conversation

donnie-msft
Copy link
Contributor

@donnie-msft donnie-msft commented Jun 18, 2024 •
edited
Loading

@albarry4 albarry4 marked this pull request as ready for review June 24, 2024 17:49
@albarry4 albarry4 requested a review from a team as a code owner June 24, 2024 17:49
@albarry4
Copy link
Contributor

albarry4 commented Jun 24, 2024 •
edited
Loading

Looks great -- once the "clear NuGet cache" button is added back in, no concerns from me!

@donnie-msft donnie-msft marked this pull request as draft June 24, 2024 18:00
@donnie-msft donnie-msft marked this pull request as draft June 24, 2024 18:00
@donnie-msft donnie-msft force-pushed the dev-donnie-msft-onboardUnifiedSettings branch from 824c4fd to b9b9b62 Compare November 20, 2024 22:51
JoshuaBStevens
JoshuaBStevens reviewed Nov 20, 2024
View reviewed changes
accepted/2024/unified-vs-settings.md Outdated Show resolved Hide resolved
accepted/2024/unified-vs-settings.md Outdated Show resolved Hide resolved
accepted/2024/unified-vs-settings.md Outdated Show resolved Hide resolved
accepted/2024/unified-vs-settings.md Show resolved Hide resolved
@donnie-msft donnie-msft marked this pull request as ready for review November 20, 2024 23:39
@donnie-msft donnie-msft requested review from a team and removed request for a team November 21, 2024 00:32
jgonz120
jgonz120 approved these changes Nov 25, 2024
View reviewed changes
accepted/2024/unified-vs-settings.md Show resolved Hide resolved
accepted/2024/unified-vs-settings.md Outdated Show resolved Hide resolved
@donnie-msft donnie-msft requested a review from OliaG November 26, 2024 18:21
@donnie-msft donnie-msft requested a review from OliaG November 26, 2024 22:14
OliaG
OliaG approved these changes Dec 3, 2024
View reviewed changes
Copy link

@OliaG OliaG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donnie-msft donnie-msft merged commit dddd1d4 into dev Dec 3, 2024
1 check passed
@donnie-msft donnie-msft deleted the dev-donnie-msft-onboardUnifiedSettings branch December 3, 2024 22:55
@donnie-msft donnie-msft mentioned this pull request Jan 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffkl jeffkl jeffkl approved these changes

@OliaG OliaG OliaG approved these changes

@jgonz120 jgonz120 Awaiting requested review from jgonz120

@JoshuaBStevens JoshuaBStevens Awaiting requested review from JoshuaBStevens

@nkolev92 nkolev92 Awaiting requested review from nkolev92

@zivkan zivkan Awaiting requested review from zivkan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@donnie-msft @albarry4 @nkolev92 @zivkan @jgonz120 @JoshuaBStevens @jeffkl @OliaG