-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PrunePackageReference (fka Supplied by platform) design #13634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like the spec explicitly states whether pruned packages will be downloaded at all. It would be good to explicitly never download pruned packages. Some vulnerability scanners look at the global packages folder, so this would ensure that those scanners wouldn't have false positives for pruned packages.
Apparently I only had that in the summary.
I'll add that explicitly in the rest of the spec as well. |
Pushed some more changes to the spec based on the feedback. |
This spec has been reviewed and now all the unresolved questions are closed. @NuGet/nuget-client Can I get another look so I can merge this. |
https://github.com/NuGet/Home/blob/dev/accepted/2024/prune-package-reference.md