Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrunePackageReference (fka Supplied by platform) design #13634

Merged
merged 18 commits into from
Nov 26, 2024

Conversation

nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Jul 17, 2024

Copy link

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like the spec explicitly states whether pruned packages will be downloaded at all. It would be good to explicitly never download pruned packages. Some vulnerability scanners look at the global packages folder, so this would ensure that those scanners wouldn't have false positives for pruned packages.

accepted/2024/supplied-by-platform.md Outdated Show resolved Hide resolved
@nkolev92
Copy link
Member Author

It doesn't look like the spec explicitly states whether pruned packages will be downloaded at all. It would be good to explicitly never download pruned packages. Some vulnerability scanners look at the global packages folder, so this would ensure that those scanners wouldn't have false positives for pruned packages.

Apparently I only had that in the summary.

This helps avoid downloading unnecessary reference and implementation packages

I'll add that explicitly in the rest of the spec as well.

@nkolev92
Copy link
Member Author

Pushed some more changes to the spec based on the feedback.
There is a limitation with transitive shared frameworks. Not sure if we have an automatic solution for that.

@nkolev92 nkolev92 marked this pull request as ready for review October 15, 2024 23:19
@nkolev92 nkolev92 requested a review from a team as a code owner October 15, 2024 23:19
@nkolev92 nkolev92 requested a review from ericstj October 15, 2024 23:19
accepted/2024/supplied-by-platform.md Outdated Show resolved Hide resolved
accepted/2024/supplied-by-platform.md Outdated Show resolved Hide resolved
@nkolev92
Copy link
Member Author

This spec has been reviewed and now all the unresolved questions are closed.

@NuGet/nuget-client Can I get another look so I can merge this.
I'm starting to PR the implementation and I want to merge the spec before that.

@nkolev92 nkolev92 changed the title Supplied by platform design PrunePackageReference (fka Supplied by platform) design Nov 22, 2024
@nkolev92 nkolev92 merged commit e4593c2 into dev Nov 26, 2024
1 check passed
@nkolev92 nkolev92 deleted the dev-nkolev92-suppliedByPlatform branch November 26, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants