Change extension methods to take in an IList instead of IEnumerable a…

…s this can avoid enumerator allocation
NuGet · Jul 30, 2024 · 0fd3911 · 0fd3911
1 parent f129eeb
commit 0fd3911
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/build/Shared/SharedExtensions.cs b/build/Shared/SharedExtensions.cs
@@ -126,13 +126,13 @@ public static void AppendInt(this StringBuilder sb, int value)
             }
         }
 
-        public static int SingleIndex<T>(this IEnumerable<T> lst, Predicate<T> isMatch)
+        public static int SingleIndex<T>(this IList<T> lst, Predicate<T> isMatch)
         {
-            var index = 0;
             var foundIndex = -1;
 
-            foreach (var item in lst)
+            for (var index = 0; index < lst.Count; index++)
             {
+                var item = lst[index];
                 if (isMatch(item))
                 {
                     if (foundIndex != -1)
@@ -142,8 +142,6 @@ public static int SingleIndex<T>(this IEnumerable<T> lst, Predicate<T> isMatch)
 
                     foundIndex = index;
                 }
-
-                index++;
             }
 
             if (foundIndex == -1)
@@ -154,17 +152,15 @@ public static int SingleIndex<T>(this IEnumerable<T> lst, Predicate<T> isMatch)
             return foundIndex;
         }
 
-        public static int FirstIndex<T>(this IEnumerable<T> lst, Predicate<T> isMatch)
+        public static int FirstIndex<T>(this IList<T> lst, Predicate<T> isMatch)
         {
-            var index = 0;
-            foreach (var item in lst)
+            for (var index = 0; index < lst.Count; index++)
             {
+                var item = lst[index];
                 if (isMatch(item))
                 {
                     return index;
                 }
-
-                index++;
             }
 
             throw new InvalidOperationException();