Enable plugin package download #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtivel
requested review from
rohit21agrawal,
nkolev92,
emgarten,
zhili1208,
alpaix,
rrelyea,
mishra14 and
jainaashish
dtivel
force-pushed
the
dev-dtivel-plugin-download-package-support
branch
3 times, most recently
from
825af55 to
b2678ce
Compare
alpaix
reviewed
May 24, 2017
| private PluginFactory _pluginFactory; | ||
| private ConcurrentDictionary<string, Lazy<Task<IReadOnlyList<OperationClaim>>>> _pluginOperationClaims; | ||
| private IPluginFactory _pluginFactory; | ||
| private ConcurrentDictionary<string, ConcurrentDictionary<string, Lazy<Task<IReadOnlyList<OperationClaim>>>>> _pluginOperationClaims; |
There was a problem hiding this comment.
Consider utilizing a combined key to avoid nested dictionaries.
dtivel
force-pushed
the
dev-dtivel-plugin-download-package-support
branch
2 times, most recently
from
f61913d to
7b385dc
Compare
… and add get service index request/response.
dtivel
force-pushed
the
dev-dtivel-plugin-download-package-support
branch
from
7b385dc to
5447019
Compare
dtivel
added a commit
that referenced
this pull request
Jun 30, 2017
dtivel
added a commit
that referenced
this pull request
Jul 10, 2017
dtivel
added a commit
that referenced
this pull request
Jul 12, 2017
This was referenced Jul 12, 2017
This was referenced Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves the following tasks:
The first 4 tasks were already code reviewed in PR #1328. However, since the merge of that PR into dev is delayed by validation, this branch is based on that private branch. As a result, this PR has all changes.
The NuGet plugin design specification is here.
CC @jmyersmsft, @cajonemsft, @zjrunner