Improving dependency path display for warnings and errors #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emgarten
requested review from
rohit21agrawal,
PatoBeltran,
nkolev92,
zhili1208,
mishra14 and
jainaashish
mishra14
approved these changes
Sep 7, 2017
| /// </summary> | ||
| NU1607 = 1607, | ||
|
|
||
| /// <summary> |
There was a problem hiding this comment.
Should we leave comment here asking people to not create these?
There was a problem hiding this comment.
I'm with @mishra14 here, we should not delete these but rather mark them as deprecated.
emgarten
force-pushed
the
dev-emgarten-getPath
branch
from
9852a7e
to
97e05b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving dependency path display for warnings and errors
This fixes how dependency paths are displayed. Currently they are written out as:
a (>= 1.0.0) -> b (>= 2.0.0)However the ranges here are made up based on the resolved version and are not the actual nuspec dependency ranges. For locked ranges such as
(= 2.0.0)the range(>= 2.0.0)is shown if 2.0.0 is found.To improve this the path will now be displayed using the actual version, and in some cases the actual range for the last node displayed since this is where the conflict is.
GetPath:
a -> b 2.0.0 -> c 1.0.0GetPathWithLastRange:
a -> b 2.0.0 -> c (>= 1.0.0)Projects will no longer display a version or range, this information is not relevant since version ranges are never applied to projects and there can only be 1 instance of a project in the graph.
Fixes NuGet/Home#5861
Fixes NuGet/Home#5852
Fixes NuGet/Home#5824