Set proxy credentials when asking a plugin for credentials. #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
requested review from
rohit21agrawal,
PatoBeltran,
zhili1208,
mishra14,
dtivel and
jainaashish
|
ping @NuGet/nuget-client |
nkolev92
force-pushed
the
dev-nkolev92-proxyCredsToPlugin
branch
from
74117f6
to
3c2ebff
Compare
nkolev92
added a commit
that referenced
this pull request
May 30, 2018
nkolev92
added a commit
that referenced
this pull request
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#6923
Regression: No
If Regression then when did it last work:
If Regression then how are we preventing it in future:
Fix
Details:
Set the proxy credentials if any when querying for credentials.
Testing/Validation
Tests Added: Yes
Reason for not adding tests:
Validation done:
TODO:
I will update the spec to call out this behavior.
//cc
@keithrob @pspill @emanuelquintero