Improve the license UI and messaging. #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
requested review from
dominoFire,
PatoBeltran,
zivkan and
jainaashish
nkolev92
changed the title
|
Nit: “View License” and not “ViewLicense” |
|
@anangaur It is "View License" in the code, I just missed the space in the description :) |
jainaashish
approved these changes
Nov 2, 2018
| @@ -140,7 +141,7 @@ | |||
| <comment>0 - the license expression, 1 further details</comment> | |||
| </data> | |||
| <data name="InvalidLicenseExpressionVersion" xml:space="preserve"> | |||
| <value>The version string '{0}' for the License Expression is invalid.</value> | |||
| <value>The version string '{0}' PackageLicenseExpressionVersion is invalid.</value> | |||
There was a problem hiding this comment.
PackageLicenseExpressionVersion '{0}' version string is invalid.
nkolev92
force-pushed
the
dev-nkolev92-licenseFeedback
branch
from
e8603d0 to
c7544f6
Compare
nkolev92
force-pushed
the
dev-nkolev92-licenseFeedback
branch
from
c7544f6 to
626ccac
Compare
PatoBeltran
approved these changes
Nov 2, 2018
| @@ -130,7 +130,8 @@ | |||
| <comment>{0} is the file being packed.</comment> | |||
| </data> | |||
| <data name="InvalidLicenseCombination" xml:space="preserve"> | |||
| <value>Invalid metadata. Cannot specify both a License Expression and a License File.</value> | |||
| <value>Invalid metadata. Cannot specify both a PackageLicenseExpression and a PackageLicenseFile.</value> | |||
| <comment>Please don't localize PackageLicenseUrl, PackageLicenseFile and PackageLicenseExpression.</comment> | |||
There was a problem hiding this comment.
nit: PackageLicenseUrl is not used in this string, remove it from the comment.
| <data name="DefaultError_NoMatchInAllowList" xml:space="preserve"> | ||
| <value>The package signature certificate fingerprint does not match any certificate fingerprint in the allow list.</value> | ||
| <data name="NuGetLicenseExpression_NonStandardIdentifier" xml:space="preserve"> | ||
| <value>The license identifier(s) {0} is(are) not recognized by the current toolset.</value> |
nkolev92
added a commit
that referenced
this pull request
Nov 5, 2018
uGet.Core/NuGet.Build.Tasks.Pack/Strings.resx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#7462, part of NuGet/Home#7467
Regression: No
If Regression then when did it last work:
If Regression then how are we preventing it in future:
Fix
Details:
Some strings changes based on the feedback from Karan.
Earlier in 15.8 in the details pane for the license field we showed a clickable license url. Per Karan's feedback, changing that to View License, which is the equivalent of what we do for embedded files.
The benefit is that an ugly url is not shown there. The con is that you don't know the exact link.
From NuGet/Home#7467 the following are fixed.
The whitespace issues with license expressions are fixed.
The weight of the header is the same as the text on the left in the same row.
The license file window appears at the middle of the screen.
The hyperlinks display a tooltip.
//cc @karann-msft @rrelyea @anangaur
Testing/Validation
Tests Added: No
Reason for not adding tests: Strings changes.
Validation done: